Skip to content

Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 3 | Quote Generator App #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TTiamiyu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 3 | Quote Generator App #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7b1d2a
Refactor index.html for improved structure and styling
TTiamiyu Jul 28, 2026
4967200
Add displayNewQuote function to show random quotes and update HTML
TTiamiyu Jul 28, 2026
f2f069e
Refactor displayNewQuote function to use getElementById for improved …
TTiamiyu Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions Sprint-3/quote-generator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,24 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<script defer src="quotes.js"></script>
</head>
<body>
<h1>hello there</h1>
<p id="quote"></p>
<p id="author"></p>
<button type="button" id="new-quote">New quote</button>
</body>
</html>

<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Quote generator app</title>
<link rel="stylesheet" href="style.css" />
</head>

<body>
<main class="quote-container">
<blockquote class="quote-box">
<p id="quote"></p>
<p id="author"></p>
</blockquote>
<button id="new-quote">New quote</button>
</main>

<!-- Connect your JavaScript file -->
<script src="quotes.js"></script>
</body>

</html>
22 changes: 22 additions & 0 deletions Sprint-3/quote-generator/quotes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,3 +491,25 @@ const quotes = [
];

// call pickFromArray with the quotes array to check you get a random quote

// Function to select a random quote and update the HTML elements
function displayNewQuote() {
const quoteP = document.getElementById("quote");
const authorP = document.getElementById("author");

// Get a random quote object from the quotes array
const randomQuote = pickFromArray(quotes);

// Update the DOM element contents
quoteP.textContent = randomQuote.quote;
authorP.textContent = randomQuote.author;
}

// 1. Display a random quote when the page initially loads
displayNewQuote();

// 2. Add a click event listener to the "New quote" button
const newQuoteBtn = document.querySelector("#new-quote");
if (newQuoteBtn) {

@LonMcGregor LonMcGregor Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use an if check here?

@TTiamiyu TTiamiyu Aug 2, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i used it to serve as a form of guardrail instruction - Only attach the event listener if the button actually exists on the page. If it doesn't, skip it and keep running the rest of the app safely.

checking online there are other ways i can achieve the same effect, do you think i should use another method?

newQuoteBtn.addEventListener("click", displayNewQuote);
}
Loading