Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 3 | Quote Generator App - #1320
Open
TTiamiyu wants to merge 3 commits into
Open
Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 3 | Quote Generator App#1320TTiamiyu wants to merge 3 commits into
TTiamiyu wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TTiamiyu
changed the title
This comment has been minimized.
This comment has been minimized.
TTiamiyu
force-pushed
the
sprint3-quote-generator-app
branch
from
July 28, 2026 01:51
a317f41 to
4967200
Compare
TTiamiyu
added
the
Needs Review
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, I have a couple of questions
|
|
||
| // Function to select a random quote and update the HTML elements | ||
| function displayNewQuote() { | ||
| const quoteP = document.querySelector("#quote"); |
There was a problem hiding this comment.
Do you need to use querySelector here? Is there a more efficient method you could use?
Author
There was a problem hiding this comment.
i found that .getElementById() works better and its also easier to read. thank you.
|
|
||
| // 2. Add a click event listener to the "New quote" button | ||
| const newQuoteBtn = document.querySelector("#new-quote"); | ||
| if (newQuoteBtn) { |
Author
There was a problem hiding this comment.
i used it to serve as a form of guardrail instruction - Only attach the event listener if the button actually exists on the page. If it doesn't, skip it and keep running the rest of the app safely.
checking online there are other ways i can achieve the same effect, do you think i should use another method?
LonMcGregor
added
Reviewed
TTiamiyu
added
the
Needs Review
|
On the if guard, this works, I wanted to make sure you understood how this worked, no need to change it. Good work on this task, it is complete now. |
LonMcGregor
added
Complete
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist