-
-
Notifications
You must be signed in to change notification settings - Fork 264
West Midlands | 26-ITP-May | Alina Sofragiu | Sprint 2 | Book-library #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sofragiualina
wants to merge
8
commits into
CodeYourFuture:main
Choose a base branch
from
sofragiualina:book-library
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
da9328e
Refactor book submission and rendering logic for improved clarity and…
sofragiualina c28263f
Enhance HTML structure and improve JavaScript functionality for book …
sofragiualina 928ef3d
Enhance pages input with step attribute
sofragiualina 246a569
Refactor form submission logic to use event listener and improve vali…
sofragiualina 3b6792f
Modify pages input field in index.html
sofragiualina b1819d3
Resolve merge conflicts
sofragiualina 1502988
Simplify input element for pages by removing unnecessary attributes
sofragiualina c4b08ea
Improved code
sofragiualina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,103 +1,107 @@ | ||
| let myLibrary = []; | ||
| const myLibrary = []; | ||
|
|
||
| window.addEventListener("load", function (e) { | ||
| window.addEventListener("load", () => { | ||
| populateStorage(); | ||
| render(); | ||
| }); | ||
| function Book(title, author, pages, check) { | ||
| this.title = title; | ||
| this.author = author; | ||
| this.pages = pages; | ||
| this.check = check; | ||
| } | ||
|
|
||
| function populateStorage() { | ||
| if (myLibrary.length == 0) { | ||
| let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); | ||
| let book2 = new Book( | ||
| "The Old Man and the Sea", | ||
| "Ernest Hemingway", | ||
| "127", | ||
| true | ||
| if (myLibrary.length === 0) { | ||
| myLibrary.push( | ||
| new Book("Robinson Crusoe", "Daniel Defoe", 252, true), | ||
| new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true) | ||
| ); | ||
| myLibrary.push(book1); | ||
| myLibrary.push(book2); | ||
| render(); | ||
| } | ||
| } | ||
|
|
||
| const title = document.getElementById("title"); | ||
| const author = document.getElementById("author"); | ||
| const pages = document.getElementById("pages"); | ||
| const check = document.getElementById("check"); | ||
| const titleInput = document.getElementById("title"); | ||
| const authorInput = document.getElementById("author"); | ||
| const pagesInput = document.getElementById("pages"); | ||
| const checkInput = document.getElementById("check"); | ||
|
|
||
| const submitButton = document.getElementById("submitButton"); | ||
|
|
||
| submitButton.addEventListener("click", submit); | ||
|
|
||
| //check the right input from forms and if its ok -> add the new book (object in array) | ||
| //via Book function and start render function | ||
| function submit() { | ||
| if ( | ||
| title.value == null || | ||
| title.value == "" || | ||
| pages.value == null || | ||
| pages.value == "" | ||
| ) { | ||
| alert("Please fill all fields!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| render(); | ||
| const title = titleInput.value.trim(); | ||
| const author = authorInput.value.trim(); | ||
| const pages = Number(pagesInput.value); | ||
|
|
||
| if (title === "" || author === "" || !Number.isInteger(pages) || pages < 1) { | ||
| alert("Please enter valid book details."); | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| function Book(title, author, pages, check) { | ||
| this.title = title; | ||
| this.author = author; | ||
| this.pages = pages; | ||
| this.check = check; | ||
| myLibrary.push(new Book(title, author, pages, checkInput.checked)); | ||
|
|
||
| titleInput.value = ""; | ||
| authorInput.value = ""; | ||
| pagesInput.value = ""; | ||
| checkInput.checked = false; | ||
|
|
||
| render(); | ||
| } | ||
|
|
||
| function render() { | ||
| let table = document.getElementById("display"); | ||
| let rowsNumber = table.rows.length; | ||
| //delete old table | ||
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| table.deleteRow(n); | ||
| } | ||
| //insert updated row and cells | ||
| let length = myLibrary.length; | ||
| for (let i = 0; i < length; i++) { | ||
| let row = table.insertRow(1); | ||
| let titleCell = row.insertCell(0); | ||
| let authorCell = row.insertCell(1); | ||
| let pagesCell = row.insertCell(2); | ||
| let wasReadCell = row.insertCell(3); | ||
| let deleteCell = row.insertCell(4); | ||
| titleCell.innerHTML = myLibrary[i].title; | ||
| authorCell.innerHTML = myLibrary[i].author; | ||
| pagesCell.innerHTML = myLibrary[i].pages; | ||
|
|
||
| //add and wait for action for read/unread button | ||
| let changeBut = document.createElement("button"); | ||
| changeBut.id = i; | ||
| changeBut.className = "btn btn-success"; | ||
| wasReadCell.appendChild(changeBut); | ||
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
|
|
||
| changeBut.addEventListener("click", function () { | ||
| myLibrary[i].check = !myLibrary[i].check; | ||
| const tbody = document.querySelector("#display tbody"); | ||
|
|
||
| tbody.textContent = ""; | ||
|
|
||
| myLibrary.forEach((book, index) => { | ||
| const row = document.createElement("tr"); | ||
|
|
||
| const titleCell = document.createElement("td"); | ||
| titleCell.textContent = book.title; | ||
|
|
||
| const authorCell = document.createElement("td"); | ||
| authorCell.textContent = book.author; | ||
|
|
||
| const pagesCell = document.createElement("td"); | ||
| pagesCell.textContent = book.pages; | ||
|
|
||
| const readCell = document.createElement("td"); | ||
|
|
||
| const readButton = document.createElement("button"); | ||
| readButton.className = "btn btn-success"; | ||
| readButton.textContent = book.check ? "Yes" : "No"; | ||
|
|
||
| readButton.addEventListener("click", () => { | ||
| book.check = !book.check; | ||
| render(); | ||
| }); | ||
|
|
||
| //add delete button to every row and render again | ||
| let delButton = document.createElement("button"); | ||
| delBut.id = i + 5; | ||
| deleteCell.appendChild(delBut); | ||
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| myLibrary.splice(i, 1); | ||
| readCell.appendChild(readButton); | ||
|
|
||
| const deleteCell = document.createElement("td"); | ||
|
|
||
| const deleteButton = document.createElement("button"); | ||
| deleteButton.className = "btn btn-warning"; | ||
| deleteButton.textContent = "Delete"; | ||
|
|
||
| deleteButton.addEventListener("click", () => { | ||
| const deletedTitle = book.title; | ||
|
|
||
| myLibrary.splice(index, 1); | ||
|
|
||
| render(); | ||
|
|
||
| // Allows the table to update before showing alert | ||
| setTimeout(() => { | ||
| alert(`You've deleted "${deletedTitle}".`); | ||
| }, 0); | ||
| }); | ||
| } | ||
|
|
||
| deleteCell.appendChild(deleteButton); | ||
|
|
||
| row.append(titleCell, authorCell, pagesCell, readCell, deleteCell); | ||
|
|
||
| tbody.appendChild(row); | ||
| }); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better practice to keep all the code that needs to be executed once on page load in the one place.