West Midlands | 26-ITP-May | Alina Sofragiu | Sprint 2 | Book-library

[sofragiualina]

… functionality

Learners, PR Template

Self checklist

• [ x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• [ x ] My changes meet the requirements of the task
• [ x ] I have tested my changes
• [ x ] My changes follow the style guide

Changelist

Fixed the Book Library bugs

[cjyuan]

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

[sofragiualina]

I've gone through the review and updated my project I fixed the HTML validation issues, improved the input validation, renamed variables to be more descriptive, used textContent instead of innerHTML where appropriate, stored the page count as a number and made other improvements

[cjyuan]

Changes look solid. I only have a few comments.

[cjyuan]

alert() is a blocking function call. As a result, invoking it prevents the browser from updating the UI until the dialog is dismissed.

If time permits, research for approaches that allows the UI to update before displaying the alert dialog. (This is an optional change).

[sofragiualina]

applied the suggested changes, thank you

[cjyuan]

Changes look good. Well done.

[cjyuan]

Better practice to keep all the code that needs to be executed once on page load in the one place.

[cjyuan]

Do checkout https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-tasklists about how to markup checkboxes in Markdown on GitHub.