Skip to content

Bound type-tree nesting depth when reading the footer #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Algunenano merged 1 commit into from
Jun 15, 2026
Merged

Bound type-tree nesting depth when reading the footer #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions c++/src/TypeImpl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,20 @@ namespace orc {
}

std::string printProtobufMessage(const google::protobuf::Message& message);
std::unique_ptr<Type> convertType(const proto::Type& type, const proto::Footer& footer) {
// Bound the recursion over the (file-controlled) type tree. The footer describes the schema as a
// tree of LIST/MAP/UNION/STRUCT types nested arbitrarily deep; a crafted deeply nested schema
// would overflow the native stack here, and later in assignIds()/buildTypeNameIdMap() which walk
// the same tree. The limit is far above any legitimate schema.
static const uint64_t MAX_TYPE_NESTING_DEPTH = 2000;

std::unique_ptr<Type> convertType(const proto::Type& type, const proto::Footer& footer,
uint64_t depth) {
if (depth > MAX_TYPE_NESTING_DEPTH) {
std::stringstream msg;
msg << "Footer is corrupt: type nesting depth exceeds the limit of " << MAX_TYPE_NESTING_DEPTH;
throw ParseError(msg.str());
}

std::unique_ptr<Type> ret;
switch (static_cast<int64_t>(type.kind())) {
case proto::Type_Kind_BOOLEAN:
Expand Down Expand Up @@ -458,7 +471,8 @@ namespace orc {
if (type.kind() == proto::Type_Kind_UNION && type.subtypes_size() == 0)
throw ParseError("Illegal UNION type that doesn't contain any subtypes");
for (int i = 0; i < type.subtypes_size(); ++i) {
ret->addUnionChild(convertType(footer.types(static_cast<int>(type.subtypes(i))), footer));
ret->addUnionChild(
convertType(footer.types(static_cast<int>(type.subtypes(i))), footer, depth + 1));
}
break;
}
Expand All @@ -470,7 +484,7 @@ namespace orc {
for (int i = 0; i < type.subtypes_size(); ++i) {
ret->addStructField(
type.field_names(i),
convertType(footer.types(static_cast<int>(type.subtypes(i))), footer));
convertType(footer.types(static_cast<int>(type.subtypes(i))), footer, depth + 1));
}
break;
}
Expand Down
3 changes: 2 additions & 1 deletion c++/src/TypeImpl.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ namespace orc {
size_t start, size_t end);
};

std::unique_ptr<Type> convertType(const proto::Type& type, const proto::Footer& footer);
std::unique_ptr<Type> convertType(const proto::Type& type, const proto::Footer& footer,
uint64_t depth = 0);

/**
* Build a clone of the file type, projecting columns from the selected
Expand Down
Loading