Bound type-tree nesting depth when reading the footer - #23
Merged
Conversation
convertType recurses over the file-controlled type tree (LIST/MAP/UNION/STRUCT) described by the footer with no depth bound, so a crafted deeply nested schema overflows the native stack here (and later in assignIds/buildTypeNameIdMap which walk the same tree). Reject nesting deeper than a fixed limit, far above any legitimate schema, with a ParseError instead of crashing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to apache#2632 the library vulnerabilities are not such:
Our model does not match this, and we handle any input. Thus we must prevent stack overflows when parsing types