Skip to content

fix(document): cap popup size at the image's natural size #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szsolt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(document): cap popup size at the image's natural size #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lua/image/utils/document.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,21 @@ local create_document_integration = function(config)

local term_size = utils.term.get_size()
if not term_size then return end

-- Cap at the image's natural width, not an unconditional screen_cols/2 --
-- otherwise a 78x20 badge also gets a half-screen window.
local natural_cols = math.ceil(image.image_width / term_size.cell_width)
local requested_cols = math.min(natural_cols, math.floor(term_size.screen_cols / 2))
local width, height = utils.math.adjust_to_aspect_ratio(
term_size,
image.image_width,
image.image_height,
math.floor(term_size.screen_cols / 2),
math.max(1, requested_cols),
0
)

-- Aspect-ratio fitting can still overshoot vertically on a tall image.
height = math.min(height, math.max(1, term_size.screen_rows - 4))
local win_config = {
relative = "cursor",
row = 1,
Expand Down