fix(document): cap popup size at the image's natural size - #375
Open
szsolt wants to merge 1 commit into
Open
Conversation
render_popup_image asked for screen_cols/2 regardless of the image, so a 78x20 badge got the same half-screen window as a 1400px chart, and with tall cells the derived height filled most of the screen. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
only_render_image_at_cursor_mode = "popup", the popup window is always sized athalf the screen width, regardless of how large the image actually is. A small image — a
78x20 shields.io badge, say — gets a half-screen float with the image in one corner and a
large empty region beside it.
The aspect-ratio fit can also overshoot vertically on a tall, narrow image, pushing the
float past the bottom of the screen.
Change
Cap the requested width at the image's natural size in cells, so the popup never asks for
more room than the image can fill:
Half the screen remains the upper bound, so large images behave exactly as before — only
images narrower than that are affected.
Then clamp the fitted height to the screen:
Notes
Platform-independent; not specific to any backend or terminal. Verified with badge-sized
and full-width images in a markdown buffer.