Skip to content

fix: CORS Defaults v3#4758

Merged
pablocarle merged 22 commits into
v3.x.xfrom
reboot/fix/permisive-cors-v3
Jul 9, 2026
Merged

fix: CORS Defaults v3#4758
pablocarle merged 22 commits into
v3.x.xfrom
reboot/fix/permisive-cors-v3

Conversation

@pablocarle

@pablocarle pablocarle commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

Cherry pick of #4718

CORS behaviour:

CORS handling setting in Gateway (apiml.service.corsEnabled) means choosing whether the Gateway will use Gateway's defaults (false, default) OR taking the southbound's services metadata to override them (true)

When false (default) is used, only one path pattern matcher is created as /**

true creates specific path patterns (/gateway/** and service-specific ones) and provides either the same defaults as when CORS handling is disabled in Gateway OR the service-specified ones.

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

Pablo Carle added 3 commits June 23, 2026 16:05
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Pablo Carle and others added 4 commits June 26, 2026 10:49
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
@pablocarle pablocarle changed the title fix: Reboot/fix/permisive cors v3 fix: CORS Defaults v3 Jun 26, 2026
@pablocarle pablocarle marked this pull request as ready for review June 26, 2026 10:14
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Comment thread common-service-core/src/main/java/org/zowe/apiml/util/CorsUtils.java Outdated
pablocarle and others added 2 commits June 30, 2026 09:15
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
@balhar-jakub balhar-jakub moved this from New to In Progress in API Mediation Layer Backlog Management Jul 1, 2026
Pablo Carle added 2 commits July 1, 2026 14:36
@pull-request-size pull-request-size Bot added size/XL and removed size/L labels Jul 1, 2026
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Comment thread common-service-core/src/main/java/org/zowe/apiml/util/CorsUtils.java Outdated
Pablo Carle added 3 commits July 7, 2026 08:45
wip
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Pablo Carle and others added 3 commits July 7, 2026 14:55
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Comment thread apiml/src/test/resources/application.yml Outdated
Pablo Carle added 2 commits July 9, 2026 15:45
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

@pablocarle pablocarle merged commit 46de7a8 into v3.x.x Jul 9, 2026
49 checks passed
@pablocarle pablocarle deleted the reboot/fix/permisive-cors-v3 branch July 9, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

4 participants