chore: minor log improvements to passtickets and applid#4647
chore: minor log improvements to passtickets and applid#4647richard-salac wants to merge 9 commits into
Conversation
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
github-project-automation
Bot
moved this to New
in API Mediation Layer Backlog Management
github-actions
Bot
added
the
Sensitive
EvaJavornicka
moved this from New
to In Progress
in API Mediation Layer Backlog Management
|
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
richard-salac
force-pushed
the
reboot/log_missing_applid
branch
from
82cb890 to
77d6c0c
Compare
richard-salac
changed the title
| private <R> Mono<AuthorizationResponse<R>> handleMissingApplicationName(OtelRequestContext context) { | ||
| private <R> Mono<AuthorizationResponse<R>> handleMissingApplicationName(String serviceId, OtelRequestContext context) { | ||
| context.authErrorType(ApplicationNameNotProvidedException.class.getName()); | ||
| log.warn("Service '{}' is missing APPLID set", serviceId); |
There was a problem hiding this comment.
I believe we still don't have infrastructure for testing log generation, am I correct?
There was a problem hiding this comment.
We could test it in acceptance tests with mockito captors, we have a few tests like these (for AT-TLS for example)
There was a problem hiding this comment.
Then, it may be relevant to add the tests, but I am not pushing on it.
There was a problem hiding this comment.
I will look into the test
There was a problem hiding this comment.
The PR #4509 changed the behavior and a request never reach the scheme transformer when the configuration is invalid.
This seems to be a dead code. I will consult with @pablocarle.
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
|
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
… and make Infinispan configuration more resilient (#4731) Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com> Signed-off-by: Elena Kubantseva <elena.kubantseva@broadcom.com> Co-authored-by: Elena Kubantseva <elena.kubantseva@broadcom.com>
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
Signed-off-by: Renovate Bot <renovate@whitesourcesoftware.com> Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com>
6 participants
Description
Minor log improvements to pass tickets and applid.
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline