Feature/new architecture#33
Conversation
- Remove deprecated __turboModuleProxy detection in index.js, use TurboModuleRegistry directly - Change TurboModuleRegistry.getEnforcing to .get to avoid iOS crash - Add @nullable annotation to oldarch getConstants() override - Add namespace in build.gradle for AGP 8+ compatibility - Fix missing trailing newlines in build.gradle and RNPowermanagerPackage.java
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1e909196c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| new ReactModuleInfo( | ||
| RNPowermanagerModuleImpl.NAME, | ||
| RNPowermanagerModuleImpl.NAME, | ||
| false, // canOverrideExistingModule | ||
| false, // needsEagerInit | ||
| false, // isCxxModule | ||
| isTurboModule // isTurboModule | ||
| )); |
There was a problem hiding this comment.
The package still advertises support for react-native >=0.71.0, but in RN 0.71/0.72 ReactModuleInfo requires the hasConstants argument before isCxxModule; this six-argument constructor is only compatible with newer RN versions. Apps using the declared minimum will fail Android compilation when this package is included, so either add the missing hasConstants value here or raise the peer dependency to the version where this constructor exists.
Useful? React with 👍 / 👎.
The 6-arg ReactModuleInfo constructor (without hasConstants) used in RNPowermanagerPackage.java only exists in RN >=0.77. The previous minimum of >=0.71.0 would cause Android compilation failures for apps on RN 0.71–0.76. BREAKING CHANGE: drops support for react-native <0.77.0
1 participant
No description provided.