add library type to ContainersFilterResult#1908
Conversation
There was a problem hiding this comment.
I'd say this is straight up wrong.
If from a library, we should still check version status like any other.
What this should really be doing is check whether it's the latest taking into account the container's project name value to look it up in the right project. Personally to me the separate library category makes no sense to me.
Why is it being part of a library relevant to anything?
should we distinguish between
library_latestandlibrary_outdated?for the sake of simplicity I decided not to
should we distinguish between
libraryandfrom_other_project(products from another project where the source project is not a library)?I think the
not_foundcategory covers this well enough for now. I can't think of a use case where users would pull in assets from another project that is not a library
Not at all, it's just a version - it just belongs to another project. When we check whether it's outdated, we should just check if the version is... regardless of where it comes from.
The bug is that we're not checking apparently across projects whether it is of the right version?
Changelog Description
add
libraryas another possible category inContainersFilterResultAdditional info
filter_containersonly knows about products from the given project_name.this causes products imported from a library to be flagged as
not_found.Some hosts use the category to mark the loader nodes different. For example
nukeuses them to apply different colors in the node graph. This PR would allow us to apply a different color to nodes reading from the library, rather than them being colored asnot_foundTesting notes:
Open Questions:
for the sake of simplicity I decided not to
I think the
not_foundcategory covers this well enough for now. I can't think of a use case where users would pull in assets from another project that is not a library