HTTP mocking: support filename option#332
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the HTTP request mocking helpers used in the WP-CLI test framework to support a filename option, enabling mocked responses to be written to disk (to emulate download/streaming behavior).
Changes:
- Add support for
filenamein the Requests transport mock to write the mocked response body to the specified file. - Add support for
filenamein the WordPresspre_http_requestmock to write the mocked body to disk. - Add a Behat scenario asserting that mocked requests with
filenamecreate the expected file contents.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Context/GivenStepDefinitions.php |
Implements filename handling in both Requests-transport and WP HTTP API mocking paths by writing the response body to disk. |
features/http-mocking.feature |
Adds functional coverage ensuring the filename option results in a file written to the test directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+324
to
328
| if ( ! empty( \$parsed_args['filename'] ) ) { | ||
| file_put_contents( \$parsed_args['filename'], \$response->body ); | ||
| } | ||
|
|
||
| return array( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.