AUTH-6733: remove commit/PR prompts from installer - #217
Conversation
The installer no longer asks "Commit the changes?" or "Create a pull request?" after a successful install. Committing and PR creation are the user's workflow, not the tool's — changes are left uncommitted for review, and the completion summary now ends with an explicit "Review the changes (git status) and commit when ready" step. Removed along with the prompts: - postInstall machine states for commit/push/PR (promptingCommit through creatingPr, checkingGhCli, showingManualInstructions) plus their actions, actors, guards, and event types - CLI/headless/dashboard adapter handlers for the commit and PR prompts - --commit/--no-commit and --create-pr flags (the post-install git workflow they toggled no longer exists) - post-install helpers (stageAndCommit, pushBranch, createPullRequest, getManualPrInstructions) and ai-content.ts (AI commit message / PR description generation), now unused - hasGhCli/getDefaultBranch git utils, only used by the removed flow detectChanges stays: it feeds the changed-files list in the completion summary, which is how the user sees what to review. Branch creation and the dirty-tree check (pre-install, --no-branch/--no-git-check) are unchanged. BREAKING CHANGE: workos install no longer commits changes or creates PRs, and the --no-commit and --create-pr flags are removed. Refs: AUTH-6733
| // Post-install: record what changed so the completion summary can list the | ||
| // files. Changes are deliberately left uncommitted for the user to review — | ||
| // the installer never commits or opens PRs on its own. | ||
| postInstall: { | ||
| initial: 'checking', | ||
| initial: 'detectingChanges', | ||
| entry: [{ type: 'emitStateEnter', params: { state: 'postInstall' } }], |
There was a problem hiding this comment.
🔍 Branch creation kept but nothing is ever committed to it
The installer still checks out a feature branch (branch:prompt / createBranch in src/lib/installer-core.ts and src/lib/run-with-core.ts:510-515) but, with commit removed, the generated work now lives as uncommitted worktree changes on that new branch. Since uncommitted changes follow the user across checkouts, the branch adds little value now and can confuse users who switch back to main and find the AuthKit files still present. Worth confirming that keeping the branch step (and its --no-branch flag) is still desired now that nothing is committed onto it.
Was this helpful? React with 👍 or 👎 to provide feedback.
Greptile SummaryThe PR removes automated commit and pull-request behavior from the AuthKit installer while preserving
Confidence Score: 5/5The PR appears safe to merge. The previously reported strict-parsing failure is fixed: both legacy commit flag forms are accepted as no-ops, warnings remain on stderr, and no blocking failure remains. Important Files Changed
|
bosun task: AUTH-6733: remove commit/PR prompts from installer
Task id: task-msh07aab-tth5
Shape: ship
Project: workos/cli