Skip to content

AUTH-6733: remove commit/PR prompts from installer - #217

Open
nicknisi wants to merge 2 commits into
mainfrom
bosun/task-msh07aab-tth5
Open

AUTH-6733: remove commit/PR prompts from installer#217
nicknisi wants to merge 2 commits into
mainfrom
bosun/task-msh07aab-tth5

Conversation

@nicknisi

@nicknisi nicknisi commented Aug 6, 2026

Copy link
Copy Markdown
Member

bosun task: AUTH-6733: remove commit/PR prompts from installer

Task id: task-msh07aab-tth5
Shape: ship
Project: workos/cli

The installer no longer asks "Commit the changes?" or "Create a pull
request?" after a successful install. Committing and PR creation are the
user's workflow, not the tool's — changes are left uncommitted for review,
and the completion summary now ends with an explicit "Review the changes
(git status) and commit when ready" step.

Removed along with the prompts:
- postInstall machine states for commit/push/PR (promptingCommit through
  creatingPr, checkingGhCli, showingManualInstructions) plus their actions,
  actors, guards, and event types
- CLI/headless/dashboard adapter handlers for the commit and PR prompts
- --commit/--no-commit and --create-pr flags (the post-install git workflow
  they toggled no longer exists)
- post-install helpers (stageAndCommit, pushBranch, createPullRequest,
  getManualPrInstructions) and ai-content.ts (AI commit message / PR
  description generation), now unused
- hasGhCli/getDefaultBranch git utils, only used by the removed flow

detectChanges stays: it feeds the changed-files list in the completion
summary, which is how the user sees what to review. Branch creation and the
dirty-tree check (pre-install, --no-branch/--no-git-check) are unchanged.

BREAKING CHANGE: workos install no longer commits changes or creates PRs,
and the --no-commit and --create-pr flags are removed.

Refs: AUTH-6733
@linear-code

linear-code Bot commented Aug 6, 2026

Copy link
Copy Markdown

AUTH-6733

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread src/lib/installer-core.ts
Comment on lines +928 to 933
// Post-install: record what changed so the completion summary can list the
// files. Changes are deliberately left uncommitted for the user to review —
// the installer never commits or opens PRs on its own.
postInstall: {
initial: 'checking',
initial: 'detectingChanges',
entry: [{ type: 'emitStateEnter', params: { state: 'postInstall' } }],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Branch creation kept but nothing is ever committed to it

The installer still checks out a feature branch (branch:prompt / createBranch in src/lib/installer-core.ts and src/lib/run-with-core.ts:510-515) but, with commit removed, the generated work now lives as uncommitted worktree changes on that new branch. Since uncommitted changes follow the user across checkouts, the branch adds little value now and can confuse users who switch back to main and find the AuthKit files still present. Worth confirming that keeping the branch step (and its --no-branch flag) is still desired now that nothing is committed onto it.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@greptile-apps

greptile-apps Bot commented Aug 6, 2026

Copy link
Copy Markdown

Greptile Summary

The PR removes automated commit and pull-request behavior from the AuthKit installer while preserving --commit and --no-commit as deprecated compatibility no-ops.

  • Simplifies the installer state machine to leave generated changes uncommitted for manual review.
  • Removes commit, push, and pull-request events, prompts, adapter handlers, utilities, and option plumbing.
  • Adds subprocess coverage confirming legacy commit flags pass strict parsing and emit warnings only on stderr.
  • Updates completion output, help metadata, and documentation for the new workflow.

Confidence Score: 5/5

The PR appears safe to merge.

The previously reported strict-parsing failure is fixed: both legacy commit flag forms are accepted as no-ops, warnings remain on stderr, and no blocking failure remains.

Important Files Changed

Filename Overview
src/bin.ts Retains both legacy commit flag forms as warned no-ops, fixing strict-parser compatibility without forwarding commit behavior.
src/bin-deprecated-flags.integration.spec.ts Exercises the real CLI to verify legacy flags parse successfully, warn on stderr, and leave machine-readable stdout clean.
src/lib/installer-core.ts Removes the commit and pull-request state-machine branches so installation proceeds directly to completion generation.
src/lib/run-with-core.ts Removes commit, push, and pull-request actor implementations and associated installer-machine wiring.
src/lib/post-install.ts Removes automated commit and pull-request helpers while retaining changed-file detection used by completion reporting.
src/lib/adapters/cli-adapter.ts Removes interactive commit and pull-request event subscriptions and prompt handlers.
src/lib/adapters/headless-adapter.ts Removes headless post-install commit and pull-request event handling.
src/utils/help-json.ts Updates machine-readable installer option metadata to represent the deprecated commit compatibility shim and removes create-pr.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[workos install] --> B[Parse installer options]
  B --> C{Legacy commit flag supplied?}
  C -->|Yes| D[Warn on stderr and continue]
  C -->|No| E[Continue]
  D --> E
  E --> F[Detect and configure project]
  F --> G[Run installation agent]
  G --> H[Build completion summary]
  H --> I[Leave changes uncommitted for review]
Loading

Reviews (2): Last reviewed commit: "fix: accept deprecated --no-commit/--com..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant