Add promoted-release finalize to the production pipeline - #23119
Merged
Conversation
Collaborator
Contributor
|
|
Contributor
|
|
jkmassel
approved these changes
Jul 21, 2026
jkmassel
left a comment
jkmassel
left a comment
Contributor
There was a problem hiding this comment.
One easy nit, another suggestion/something to keep an eye out for when you wire it up to Buildkite.
| version_code = version_code.to_s.strip | ||
| UI.user_error!('`version_code` is required, e.g. `version_code:270084231`') if version_code.empty? | ||
| UI.user_error!("`version_code` must be an integer, got #{version_code.inspect}") unless version_code.match?(/\A\d+\z/) | ||
| version_code = Integer(version_code) |
Contributor
There was a problem hiding this comment.
nit: specifying base10 ensures that we don't get weird behaviour if I pass in 0270084231 instead of 270084231.
Suggested change
| version_code = Integer(version_code) | |
| version_code = Integer(version_code, 10) |
| released_version = marketing_version_for(version_code: version_code) | ||
| UI.important("Finalizing promoted release #{released_version} (build #{version_code})") | ||
|
|
||
| release_url = create_draft_github_release(version_code: version_code, version_name: released_version) |
Contributor
There was a problem hiding this comment.
Should we check if the given version already exists (for instance, if this lane is run twice)?
Or will we just disable retry in the Buildkite pipeline config?
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
After the Play submit, resolve the released build's commit from the versionCode's Buildkite build number, create a draft GitHub release tagged at that commit (signed universal APKs attached best-effort), and open a PR bumping trunk's marketing version to the next line. Runs on mac-metal as a step appended after promote_to_production; only failures notify Slack.
Splits the block, promote, and finalize steps out of write_production_release_steps_file so it reads as a clean list and stays under rubocop's MethodLength after the finalize step was added.
Avoids Integer() treating a leading-zero value as octal.
finalize_promoted_release can be re-run for the same build; reuse the existing release (matched by target_commitish) instead of creating a second draft.
oguzkocer
force-pushed
the
task/finalize-production-release
branch
from
July 21, 2026 20:12
895f9c1 to
7669dff
Compare
oguzkocer
enabled auto-merge (squash)
July 21, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the git/GitHub ceremony that runs after a build is promoted to production: a
finalize_promoted_releasefastlane lane, appended to the promote-to-production pipeline as amac-metalstep after theandroidpromote step (gated by the same confirmation; skipped if the promote didn't run).versionCode % 1_000_000→ Buildkite build number → that build's commit SHA), so no per-build tagging is needed.26.9 → 27.0); no-op if trunk is already ahead.Testing instructions
No manual test steps. @jkmassel and I discussed and agreed on this testing methodology: this is a best-attempt PR. We'll exercise it as part of an upcoming release and fix any issues in a follow-up PR.