Correct reassembly logic in sniffer. Fix handshake message size in BuildCertificateStatus. Ensure MTU is set properly when using SCTP with DTLS. Improve SCTP examples. - #11211
Open
kareem-wolfssl wants to merge 4 commits into
Conversation
Thanks to 007bsd for the report.
This was causing issues when using OCSP stapling with secure_renegotiation and renegotiating a connection. Thanks to 007bsd for the report.
… checks and fix wolfSSL_shutdown handling in SCTP examples.
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes sniffer reassembly, OCSP handshake sizing, and DTLS-over-SCTP MTU handling while improving associated tests and examples.
Changes:
- Corrects overlapping TCP segment reassembly.
- Uses the actual CertificateStatus body length.
- Adds SCTP MTU coverage and stronger SCTP examples.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/utils.h |
Adds SCTP stream-mode state. |
tests/utils.c |
Preserves partial SCTP reads. |
tests/api/test_ocsp.h |
Declares the OCSP regression test. |
tests/api/test_ocsp.c |
Tests encrypted CertificateStatus renegotiation. |
tests/api/test_dtls.h |
Registers SCTP MTU coverage. |
tests/api/test_dtls.c |
Tests large SCTP application records. |
tests/api.c |
Adds sniffer overlap regression coverage. |
src/sniffer.c |
Corrects overlap trimming and reassembly. |
src/internal.c |
Fixes handshake sizing and changes MTU selection. |
examples/sctp/sctp-server-dtls.c |
Improves error handling and shutdown. |
examples/sctp/sctp-client-dtls.c |
Validates I/O and shutdown results. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#22352, zd#22354, zd#22348
Testing
Built in tests, added tests
Checklist