ntp CI: build wolfSSL with OPENSSL_EXTRA_BSD and MD4 - #11207
Merged
Conversation
The ntp 4.2.8p18 patch (wolfSSL/osp) requires wolfSSL to be built with OPENSSL_EXTRA_BSD, which provides MD5Init/MD5Update/MD5Final, and with MD4 for the new test suite. Neither is provided by --enable-all. Without these flags the 4.2.8p18 job fails at configure with a clear error.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the NTP GitHub Actions workflow to build wolfSSL with the additional OpenSSL-compat and legacy-hash options needed by the NTP 4.2.8p18 wolfSSL/osp patch and its associated tests.
Changes:
- Extend the wolfSSL configure flags in the NTP CI job to include
--enable-md4. - Add
-DOPENSSL_EXTRA_BSDviaCFLAGSsoMD5Init/MD5Update/MD5Finalare available for the 4.2.8p18 build.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
philljj
self-requested a review
August 19, 2026 20:33
philljj
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ntp 4.2.8p18 patch (wolfSSL/osp) requires wolfSSL to be built with
OPENSSL_EXTRA_BSD, which providesMD5Init/MD5Update/MD5Final, and with MD4 for the new test suite. Neither is provided by--enable-all, so without these flags the 4.2.8p18 job fails at configure with a clear error.