Add separate client cookie enable config

[padelsbach]

Description

Split the existing flag which enables TLS cookie support WOLFSSL_SEND_HRR_COOKIE into a smaller portion WOLFSSL_TLS13_COOKIE which enables replying with a cookie echo'ed from the HelloClientResponse (HRR). This is enabled by default for clients.

Fixes #11074

Testing

New unit test

Checklist

• added tests
• updated/added doxygen
• updated appropriate READMEs
• Updated manual and documentation

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #11101

Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src

Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

[github-actions]

MemBrowse Memory Report

gcc-arm-cortex-m4-dtls13

• FLASH: .text +64 B (+0.0%, 183,740 B / 1,048,576 B, total: 18% used)

gcc-arm-cortex-m4-openssl-compat

• FLASH: .rodata +56 B, .text +384 B (+0.1%, 776,980 B / 1,048,576 B, total: 74% used)

gcc-arm-cortex-m4-pq

• FLASH: .text +320 B (+0.1%, 298,268 B / 1,048,576 B, total: 28% used)

gcc-arm-cortex-m4-rsa-only

• FLASH: .text +320 B (+0.1%, 328,880 B / 1,048,576 B, total: 31% used)

gcc-arm-cortex-m4-tls13

• FLASH: .text +320 B (+0.1%, 239,073 B / 262,144 B, total: 91% used)

gcc-arm-cortex-m7-pq

• FLASH: .text +320 B (+0.1%, 299,228 B / 1,048,576 B, total: 29% used)

gcc-arm-cortex-m7-tls13

• FLASH: .text +320 B (+0.1%, 239,137 B / 262,144 B, total: 91% used)
  No memory changes detected for:
• gcc-arm-cortex-m0plus
• gcc-arm-cortex-m3
• gcc-arm-cortex-m4
• gcc-arm-cortex-m4-baremetal
• gcc-arm-cortex-m4-crypto-only
• gcc-arm-cortex-m4-min-ecc
• gcc-arm-cortex-m4-pkcs7
• gcc-arm-cortex-m4-sp-math
• gcc-arm-cortex-m4-tls12
• gcc-arm-cortex-m7
• linuxkm-pie
• linuxkm-standard
• stm32-sim-stm32h753

[dgarske]

Jenkins retest this please

[dgarske]

Testing configuration:
--enable-tls13 --disable-tlsv12 --enable-secure-renegotiation --enable-nullcipher CFLAGS="-DNO_WOLFSSL_CLIENT"

   1579: test_tls13_server_cookie_parse                     :
ERROR - tests/api/test_tls13.c line 7835 failed with:
    expected: TLSX_Parse(ssl, badExt, (word16)sizeof(badExt), client_hello, (Suites*)((const Suites*) ((ssl)->suites != ((void *)0) ? (ssl)->suites : (ssl)->ctx->suites))) == (BUFFER_E)
    result:   0 != -132
 failed (  0.00005)
ERROR - tests/api.c line 39831 failed with:
    expected: Test failed
    result:   ret 0

[padelsbach]

jenkins retest this please

[Copilot]

Pull request overview

Adds default TLS 1.3 client support for echoing HRR cookies, addressing #11074 while retaining server-side opt-in.

Changes:

• Introduces client-side cookie support and a configurable size limit.
• Separates client echo behavior from server cookie generation.
• Adds handshake, parsing, echo, and size-limit tests.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
wolfssl/internal.h	Defines cookie capability, limit, and state.
src/tls.c	Parses, stores, and echoes HRR cookies.
src/tls13.c	Accepts cookie-only HRRs.
src/ssl.c	Resets cookie state on reuse.
tests/api/test_tls13.c	Adds cookie behavior tests.
tests/api/test_tls13.h	Registers new tests.
configure.ac	Clarifies Autotools option behavior.
CMakeLists.txt	Clarifies CMake option behavior.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[philljj]

nit: this is a little confusing.

RFC 8446 4.2.2 says upper bound is 2 ** 16 - 1 = 65535.

This test requires WOLFSSL_MAX_TLS13_COOKIE_SZ <= 65528 because 2 ** 16 - 1 - 1 - 6 = 65528.

[padelsbach]

comment updated