Fix retry loop in doAutopilot#993
Open
yosuke-wolfssl wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the non-blocking autopilot path resolution flow in examples/sftpclient by correcting the retry behavior around wolfSSH_SFTP_RealPath() and refactoring that logic into a helper so autopilot transfers use the intended absolute remote path (CWD + relative remote).
Changes:
- Add
doRealPath()helper to resolve the remote CWD viawolfSSH_SFTP_RealPath(".", ...)and build a full remote path. - Update
doAutopilot()to use the helper and retry resolution after rekeying / window-full states.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The loop's continuation in doAutopilot() is ((err == WS_WANT_READ || err == WS_WANT_WRITE) && ret != WS_SUCCESS), but the right-hand operand is always false, so the loop never iterates a second time. In non-blocking mode (-N), wolfSSH_SFTP_RealPath can legitimately return NULL with err == WS_WANT_READ; instead of retrying, the code falls through to use name == NULL and silently builds the path as "./" (see snprintf at line 1328-1330). The subsequent transfer is therefore performed against the wrong (relative) path.
Changes
This PR fixes the above issue and adds small helper to refactor the flow.
Addressed by f_4103