Add lib/ dir to contain submodules. Add wolfHAL as a submodule. - #152
Open
AlexLanzano wants to merge 1 commit into
Open
Add lib/ dir to contain submodules. Add wolfHAL as a submodule.#152AlexLanzano wants to merge 1 commit into
AlexLanzano wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a lib/ directory and migrates wolfHAL integration to a lib/wolfHAL git submodule, updating build/CI paths and documentation to use the submodule instead of fetching a pinned commit during CI.
Changes:
- Add
lib/wolfHALas a git submodule (via.gitmodules) and switch builds to use it as the default wolfHAL source. - Update GitHub Actions to checkout submodules rather than cloning wolfHAL by commit hash.
- Update local CI script + documentation to initialize the wolfHAL submodule for local builds.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/scripts/run-m33mu-ci-in-container.sh | Switch local wolfHAL setup from pinned fetch to initializing the lib/wolfHAL submodule. |
| src/port/wolfHAL/README.md | Document building with wolfHAL via the lib/wolfHAL submodule and how to initialize it. |
| src/port/stm32h563/Makefile | Change default WOLFHAL_ROOT to $(ROOT)/lib/wolfHAL and update the missing-wolfHAL guidance. |
| .gitmodules | Define lib/wolfHAL as a submodule pointing at wolfSSL/wolfHAL. |
| .github/workflows/wolfhal-stm32h563zi-nucleo.yml | Update CI to checkout submodules instead of cloning wolfHAL via an env-pinned ref. |
Suppressed comments (1)
src/port/wolfHAL/README.md:39
- Clarify that the submodule init command should be run from the repository root; otherwise users building from within
src/port/stm32h563/may copy/paste a command that fails due to the relativelib/wolfHALpath.
Initialize the submodule once with
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AlexLanzano
force-pushed
the
add-submodule
branch
from
August 16, 2026 18:49
b4c02cf to
90ec8cf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/port/wolfHAL/README.md:37
- The README states
WOLFHAL_ROOT ?= lib/wolfHAL, but builds are typically invoked withmake -C src/port/stm32h563 .... Because-Cchanges Make's working directory tosrc/port/stm32h563, a relativeWOLFHAL_ROOT=lib/wolfHALwould resolve tosrc/port/stm32h563/lib/wolfHAL(nonexistent). This documentation should match the Makefile default ($(ROOT)/lib/wolfHAL) or otherwise clarify that it must be relative tosrc/port/stm32h563.
pulls the wolfHAL STM32H5 driver TUs from the `lib/wolfHAL` submodule
(`WOLFHAL_ROOT ?= lib/wolfHAL`), and compiles the port's `main.c` against
wolfHAL drivers instead of the hand-rolled bare-metal ones.
dgarske
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/directory