Skip to content

Add lib/ dir to contain submodules. Add wolfHAL as a submodule. - #152

Open
AlexLanzano wants to merge 1 commit into
wolfSSL:masterfrom
AlexLanzano:add-submodule
Open

Add lib/ dir to contain submodules. Add wolfHAL as a submodule.#152
AlexLanzano wants to merge 1 commit into
wolfSSL:masterfrom
AlexLanzano:add-submodule

Conversation

@AlexLanzano

Copy link
Copy Markdown
Member
  • Add lib/ directory
  • Add wolfHAL as a submodule
  • Update CI to build against the submodule instead of a commit hash
  • Update documentation to include pulling in the submodule when building with wolfHAL

@AlexLanzano AlexLanzano self-assigned this Aug 16, 2026
Copilot AI lite review requested due to automatic review settings August 16, 2026 18:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a lib/ directory and migrates wolfHAL integration to a lib/wolfHAL git submodule, updating build/CI paths and documentation to use the submodule instead of fetching a pinned commit during CI.

Changes:

  • Add lib/wolfHAL as a git submodule (via .gitmodules) and switch builds to use it as the default wolfHAL source.
  • Update GitHub Actions to checkout submodules rather than cloning wolfHAL by commit hash.
  • Update local CI script + documentation to initialize the wolfHAL submodule for local builds.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/scripts/run-m33mu-ci-in-container.sh Switch local wolfHAL setup from pinned fetch to initializing the lib/wolfHAL submodule.
src/port/wolfHAL/README.md Document building with wolfHAL via the lib/wolfHAL submodule and how to initialize it.
src/port/stm32h563/Makefile Change default WOLFHAL_ROOT to $(ROOT)/lib/wolfHAL and update the missing-wolfHAL guidance.
.gitmodules Define lib/wolfHAL as a submodule pointing at wolfSSL/wolfHAL.
.github/workflows/wolfhal-stm32h563zi-nucleo.yml Update CI to checkout submodules instead of cloning wolfHAL via an env-pinned ref.
Suppressed comments (1)

src/port/wolfHAL/README.md:39

  • Clarify that the submodule init command should be run from the repository root; otherwise users building from within src/port/stm32h563/ may copy/paste a command that fails due to the relative lib/wolfHAL path.
Initialize the submodule once with

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tools/scripts/run-m33mu-ci-in-container.sh
Comment thread src/port/wolfHAL/README.md
Comment thread src/port/stm32h563/Makefile

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/port/wolfHAL/README.md:37

  • The README states WOLFHAL_ROOT ?= lib/wolfHAL, but builds are typically invoked with make -C src/port/stm32h563 .... Because -C changes Make's working directory to src/port/stm32h563, a relative WOLFHAL_ROOT=lib/wolfHAL would resolve to src/port/stm32h563/lib/wolfHAL (nonexistent). This documentation should match the Makefile default ($(ROOT)/lib/wolfHAL) or otherwise clarify that it must be relative to src/port/stm32h563.
pulls the wolfHAL STM32H5 driver TUs from the `lib/wolfHAL` submodule
(`WOLFHAL_ROOT ?= lib/wolfHAL`), and compiles the port's `main.c` against
wolfHAL drivers instead of the hand-rolled bare-metal ones.

@dgarske dgarske removed their assignment Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants