Fix inconsistent locals usage in middleware code examples#14106
Merged
Conversation
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Preview deployment ✅ Deployment complete!
|
ArmandPhilippot
approved these changes
Jun 20, 2026
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
Member
There was a problem hiding this comment.
Thank you, really helpful! 🙌🏽 And, you caught more things than me!
ArmandPhilippot
added
the
code snippet update
HiDeoo
added a commit
that referenced
this pull request
Jun 22, 2026
* main: Fix inconsistent locals usage in middleware code examples (#14106) i18n(ko-KR): update multiple pages (#14100) Fix TypeScript errors in "Add content to your site" code snippets (#14091) Fix TypeScript errors in "Server rendering" code snippets (#14092) Fix TypeScript errors in "Build your UI" code snippets (#14090) i18n(pt-br): translate recipes/modified-time.mdx (#14096) i18n(pt-br): translate recipes/external-links.mdx (#14097) i18n(pt-br): fix broken link (#14093) i18n(fr): update `guides/i18n` & `modules/astro-i18n` (#14087) i18n(pt-br): bring astro:config module reference up-to-date (#14085) i18n(pt-br): translate recipes/reading-time.mdx (#14088) i18n(ko-KR): update `astro-i18n`, `internationalization` (#14086)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
The middleware examples reference
localsproperties (property,orders) that are never set, which can confuse readers. This PR sets every value the example.astrofiles read so the snippets are self-consistent and runnable, and fixes two latent bugs in the second example (assigning.nameon an uninitializeduser, and referencing an undefinedlocalsinstead ofcontext.locals).Related issues & labels (optional)