Fix WithParam RejectOnMatch inverting the match result #1496 - #1497
Open
Bafyn wants to merge 1 commit into
Open
Conversation
Bafyn
force-pushed
the
fix/withparam-rejectonmatch-inverted
branch
from
August 11, 2026 19:09
37a7eb8 to
ab0825f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WithParam(key, MatchBehaviour.RejectOnMatch, values)returns the opposite result: a request whose param value equals the reject value matches (should be rejected), and a different value doesn't match (should be accepted).AcceptOnMatchis unaffected.Cause
RequestMessageParamMatcher'sparams string[] valuesctor injectsmatchBehaviourinto each innerExactMatcher(which already runsMatchBehaviourHelper.Convert), andGetMatchingScorerunsConvertagain on the aggregate - so it's applied twice.Fix
Create the inner
ExactMatcherwithAcceptOnMatch; the behaviour is now applied once byGetMatchingScore.AcceptOnMatchoutput is unchanged.Tests
RequestMessageParamMatcherTests=> RejectOnMatch match/non-match (+ignoreCase) and AcceptOnMatch regressions.WireMockServerTests.WithParam:?k=abc=> 404,?k=xyz=> 200.References
Fixes #1496
Submitter checklist