Fixed edge arrange when vertices are overlapping#27
Merged
Conversation
carl-andersson-at-westermo
requested review from
AndersPantzarWestermo and
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an Avalonia layout/arrange crash when edge endpoints coincide (overlapping vertices), improving stability of edge label positioning (and adding regression coverage) in the GraphX Avalonia controls library.
Changes:
- Guard against zero direction vectors when normalizing the edge midpoint vector during label arrangement.
- Skip arranging labels when computed label coordinates/sizes are non-finite to avoid invalid arrange rectangles.
- Add a regression test covering overlapping vertices with an attached label (and an edge pointer template).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Westermo.GraphX.Controls.Avalonia/Controls/EdgeControlBase.cs | Adds guards to prevent NaN/Infinity propagation into label (and related) arrange logic when vertices overlap. |
| Westermo.GraphX.Controls.Avalonia.Tests/EdgeControlAdvancedTests.cs | Adds a regression test ensuring overlapping vertices + label does not throw during arrange. |
AndersPantzarWestermo
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.