Skip to content

feat: add -schemaHash=false to omit schema hash from header comment#33

Merged
pkieltyka merged 1 commit into
webrpc:masterfrom
klaidliadon:feat/optional-version-funcs
Jun 19, 2026
Merged

feat: add -schemaHash=false to omit schema hash from header comment#33
pkieltyka merged 1 commit into
webrpc:masterfrom
klaidliadon:feat/optional-version-funcs

Conversation

@klaidliadon

@klaidliadon klaidliadon commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

The schema hash in the OpenAPI header comment changes on every schema edit, causing frequent git conflicts in the generated YAML. This adds a -schemaHash target option (default true) to omit it when wanted — default behavior is unchanged, so it's non-breaking.

Part of a coordinated change across the webrpc generators. The maintainer's call is that the hash stays on by default and omission is opt-out.


Behavior

  • default / -schemaHash: header comment unchanged (# <name> <version> <hash>).
  • -schemaHash=false: header comment carries only name + version. The DO NOT EDIT line stays.

@klaidliadon klaidliadon force-pushed the feat/optional-version-funcs branch from 49dd074 to c59f1ef Compare June 19, 2026 12:15
@klaidliadon klaidliadon changed the title feat: make schema hash in header comment opt-in via -versionFuncs feat: make schema hash in header comment opt-in via -schemaHash Jun 19, 2026
The schema hash in the OpenAPI header comment changes on every schema edit,
causing frequent git conflicts in the generated YAML. This adds a -schemaHash
target option (default true) to omit it when desired.

- default (or -schemaHash): header comment unchanged (name, version, hash).
- -schemaHash=false: header comment carries only the name and version. The
  "Code generated by ... DO NOT EDIT" line stays.

Default behavior is unchanged, so this is non-breaking.
@klaidliadon klaidliadon force-pushed the feat/optional-version-funcs branch from c59f1ef to cace5c2 Compare June 19, 2026 13:50
@klaidliadon klaidliadon changed the title feat: make schema hash in header comment opt-in via -schemaHash feat: add -schemaHash=false to omit schema hash from header comment Jun 19, 2026
@pkieltyka pkieltyka merged commit bc83eca into webrpc:master Jun 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants