Skip to content

fix: the ASCII whitespaces are preserved so can not be escaped#1632

Closed
JounQin wants to merge 3 commits into
webpack:masterfrom
JounQin:patch-1
Closed

fix: the ASCII whitespaces are preserved so can not be escaped#1632
JounQin wants to merge 3 commits into
webpack:masterfrom
JounQin:patch-1

Conversation

@JounQin

@JounQin JounQin commented Apr 16, 2025

Copy link
Copy Markdown
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

close #1626

Breaking Changes

N/A

Additional Info

related https://infra.spec.whatwg.org/#ascii-whitespace

cc @alexander-akait

@JounQin JounQin changed the title fix: ASCII whitespaces are preserved can can not be escaped fix: the ASCII whitespaces are preserved so can not be escaped Apr 16, 2025
@codecov

codecov Bot commented Apr 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (f5be49c) to head (902754f).
Report is 48 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1632      +/-   ##
==========================================
+ Coverage   96.15%   96.28%   +0.12%     
==========================================
  Files          10       10              
  Lines        1196     1210      +14     
  Branches      461      465       +4     
==========================================
+ Hits         1150     1165      +15     
- Misses         37       40       +3     
+ Partials        9        5       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread test/__snapshots__/modules-option.test.js.snap
@JounQin JounQin force-pushed the patch-1 branch 4 times, most recently from f38ba36 to cdb15b0 Compare May 2, 2025 06:19
Comment thread src/utils.js

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for, will wait your answer before merge

@snitin315 snitin315 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JounQin

JounQin commented May 18, 2025

Copy link
Copy Markdown
Member Author

@alexander-akait @snitin315 Any ETA to merge and release?

@alexander-akait

Copy link
Copy Markdown
Member

@JounQin this week

@JounQin

JounQin commented Jun 27, 2025

Copy link
Copy Markdown
Member Author

Friendly ping @alexander-akait @snitin315 @ersachin3112

@JounQin

JounQin commented Mar 2, 2026

Copy link
Copy Markdown
Member Author

@alexander-akait Hi, why this PR is closed?

@JounQin

JounQin commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

@alexander-akait News?

@alexander-akait

Copy link
Copy Markdown
Member

@JounQin Oh, sorry, looks like by mistake, but looks like the branch is deleted, I can't reopen, do you try experiments.css? It is replace for css-loader, style-loader and mini-css-extract-plugin (faster and without bugs), just want to get feedback, if you need examples feel free to look webpack/examples/css, we want to deprecated these packages soon (after the next minor release in favor of experiments.css), anyway I can merge it and make a release

@JounQin

JounQin commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

@alexander-akait Thanks, that's weird I didn't delete the branch, but can recreate the PR. I'll try experiments.css later, but that's a different task, thanks!

@JounQin

JounQin commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

@alexander-akait #1668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS modules with path which contains spaces does not work as expected

3 participants