fix: write the footer brand credit as WebJs, not lowercase - #1191
Merged
Conversation
Invariant 11 capitalizes the brand wherever it names the project in prose, reserving the lowercase form for literal code tokens (a CLI command, the domain, an @webjsdev package, a config key, an env var). The footer credit was prose, so it should always have read "Built with WebJs". It renders on every page, which made it the most-viewed instance of the name written wrongly, and it contradicted the scaffold, which already emits the capitalized form (packages/cli/lib/create.js L1384). Add the SSR assertion alongside it. The edit-time hook that enforces casing only scans NEW content, so a string already in the tree is never re-checked and CI has no equivalent, which is exactly how this survived. The test also pins the comparison hrefs as lowercase, so a later over-eager fix cannot "correct" the url paths and break those links. Counterfactual verified: reverting the source line fails the new test on the brand-casing assertion specifically. Closes #1190
vivek7405
marked this pull request as ready for review
July 30, 2026 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/cli/lib/create.jsL1384).Test plan
/compare/webjs-vs-*hrefs as lowercase, so a later over-eager fix cannot "correct" url paths and break those linksgrep -rn "Built with webjs"returns no hits outsidenode_moduleswebjs checkclean, full website suite passesCloses #1190