fix(task-refactor): fix task-refactor e2e#713
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0db2290e9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await testManager.basicSetup(browser); | ||
| await enableMultiLogin(testManager.agent1Page); |
There was a problem hiding this comment.
Enable multi-login before widget initialization
Here basicSetup() has already initialized the widgets via the desktop pageSetup() path, which disables multi-login before SDK initialization; the sample app warns that changing samples:multi-login-enable-checkbox after SDK initialization has no effect (widgets-samples/cc/samples-cc-react-app/src/App.tsx lines 636-638). In filtered runs of just should test multi-session synchronization (or if the earlier reload test is skipped), agent1's SDK remains single-login while the second session is initialized, so the test depends on a previous reload to pass instead of being independently runnable. Enable multi-login before widget initialization or reload/reinitialize immediately after setting it.
Useful? React with 👍 / 👎.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-8061
This pull request addresses
< DESCRIBE THE CONTEXT OF THE ISSUE >
by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.