fix: preserve stem position attributes on round-trip#265
Merged
Conversation
Add isOctaveChangeSpecified to ClefData, mirroring the isLineSpecified pattern. The writer guard was != 0, dropping valid <clef-octave-change>0</…> elements on round-trip. Fixes #257.
dump-api-roundtrip and classify-api-roundtrip wrote output into the Docker volume, invisible on the host. Add a post-run copy step to extract roundtrip-dump/ and classified.json to the host build/ directory.
webern
added
bug
Coverage reportCore-dev coverage
|
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 77.8% | 28487 / 36624 |
| Functions | 74.3% | 6349 / 8550 |
| Branches | 50.6% | 22632 / 44725 |
API coverage src/private/mx/{api,impl,utility}/
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 78.3% | 6012 / 7675 |
| Functions | 63.7% | 2042 / 3207 |
| Branches | 47.5% | 5090 / 10707 |
Core HTML report | API HTML report
Commit 1f775e3d89023af9ef04aa4ab5dc9820375135fe.
gen-quality
|
Coverage reportCore-dev coverage
|
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 77.8% | 28487 / 36624 |
| Functions | 74.3% | 6349 / 8550 |
| Branches | 50.6% | 22632 / 44725 |
API coverage src/private/mx/{api,impl,utility}/
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 78.3% | 6012 / 7675 |
| Functions | 63.7% | 2044 / 3208 |
| Branches | 47.6% | 5092 / 10707 |
Core HTML report | API HTML report
Commit b9873ecea290286e4d06d38b12756081f943daee.
gen-quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
stemPositionDatatoNoteDataso that position attributes on<stem>elements(
default-x,default-y,relative-x,relative-y) survive the api round-trip. Previouslythe reader extracted only the stem direction enum and the writer created a bare
core::Stemwith no position attributes, so
<stem default-y="0">up</stem>lost itsdefault-y.The fix reuses the existing
PositionDatastruct and thegetPositionData/setAttributesFromPositionDatatemplates from
PositionFunctions.hwhich already handle the newoptional<Tenths>core APIvia C++20
requiresdetection.Changes
NoteData.h- addPositionData stemPositionDatafield and equality memberNoteFunctions.cpp- extract stem position data viagetPositionData(*myNote.stem())NoteWriter.cpp- apply stem position data viasetAttributesFromPositionDatabefore emittingTesting
attr:stem@default-ysignature eliminated from classifier worklistksuite/k002a_Fermatas.xmlflips to PASS (sole blocker was this signature)References