Skip to content

Add COOP/COEP support and fix threaded loader script#48

Merged
kalwalt merged 5 commits into
devfrom
feat/update-examples
Jun 26, 2026
Merged

Add COOP/COEP support and fix threaded loader script#48
kalwalt merged 5 commits into
devfrom
feat/update-examples

Conversation

@kalwalt

@kalwalt kalwalt commented Jun 25, 2026

Copy link
Copy Markdown
Member

This pull request introduces several improvements to the project, primarily focusing on modernizing the example HTML files, adding local development instructions, and including IDE configuration files. The most significant changes are the refactoring of the ARToolkitNFT_ES6_example.html and ARToolkitNFT_ES6_threading_example.html files to use ES6 modules and import maps, improved handling of cross-origin isolation for threaded examples, and the addition of documentation for local development.

Example HTML modernization and module support:

  • Refactored examples/ARToolkitNFT_ES6_example.html and examples/ARToolkitNFT_ES6_threading_example.html to use ES6 modules, import maps for three.js, and module-based script loading, replacing legacy script includes and improving code structure. [1] [2] [3] [4] [5] [6]
  • Improved code readability and HTML semantics in both example files (e.g., consistent indentation, lang="en", and video tag formatting). [1] [2]

Cross-origin isolation handling for threading:

  • Added a runtime check and reload logic in ARToolkitNFT_ES6_threading_example.html to ensure cross-origin isolation (COOP/COEP) is enabled, which is required for threading support in web workers. This includes user feedback and error handling if isolation cannot be established.

Documentation improvements:

  • Updated Readme.md with instructions for local development, including how to serve the site with the necessary COOP/COEP headers for threaded examples, and notes on Netlify configuration.

IDE/editor support:

  • Added .idea directory files (.gitignore, modules.xml, vcs.xml, webarkit.github.io.iml) to support JetBrains IDE project configuration and version control integration. [1] [2] [3] [4]

These changes collectively improve the developer experience, modernize the codebase for current JavaScript standards, and ensure compatibility with features that require enhanced browser security settings.

kalwalt and others added 2 commits June 25, 2026 15:35
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kalwalt kalwalt self-assigned this Jun 25, 2026
@kalwalt kalwalt added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jun 25, 2026
@kalwalt kalwalt merged commit 17f5994 into dev Jun 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant