feat: add endpoint setting for text2vec-openai and text2vec-morph#2090
Open
muhammadshayan124 wants to merge 1 commit into
Open
feat: add endpoint setting for text2vec-openai and text2vec-morph#2090muhammadshayan124 wants to merge 1 commit into
muhammadshayan124 wants to merge 1 commit into
Conversation
Adds an optional `endpoint` argument to Configure.Vectorizer.text2vec_openai, Configure.Vectors.text2vec_openai, Configure.Vectors.text2vec_morph, and Configure.NamedVectors.text2vec_openai, mirroring the `endpoint` field already supported by text2vec-aws. Defaults to None, which uses the server-defined default of /v1/embeddings. Closes weaviate#2072
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
endpointargument totext2vec-openaiandtext2vec-morphvectorizer configs, mirroring theendpointfield already supported bytext2vec-aws. Defaults toNone, which uses the server-defined default of/v1/embeddings.Closes #2072.
Changes
weaviate/collections/classes/config_vectorizers.py: addsendpoint: Optional[str]to_Text2VecOpenAIConfigand_Text2VecMorphConfig, and threads it throughConfigure.Vectorizer.text2vec_openai.weaviate/collections/classes/config_vectors.py: addsendpointtoConfigure.Vectors.text2vec_openaiandConfigure.Vectors.text2vec_morph.weaviate/collections/classes/config_named_vectors.py: addsendpointtoConfigure.NamedVectors.text2vec_openai(there is notext2vec_morphnamed-vector factory to update).test/collection/test_config.py: adds a case per updated factory assertingendpointround-trips into the serialized module config.Test plan
pytest test/collection/test_config.py— 194/194 passingruff check/ruff format --checkon all changed files — cleanflake8on all changed files — clean