-
Notifications
You must be signed in to change notification settings - Fork 3
fix PolicyResource: null date should not default to valid date
#1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+63
−2
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
736f2e9
drive-by cleanup
deer-wmde fbf9d3f
add PolicyResourceTest
deer-wmde 5f2c8ca
guardrail for null activeFrom
deer-wmde 5fe2d9b
extend test
deer-wmde 445adda
formatting
deer-wmde aa7c259
Update app/Http/Resources/PolicyResource.php
deer-wmde a26d10d
fixes
deer-wmde fc00a0d
add explicit null test case
deer-wmde 9be7894
cleanup
deer-wmde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| <?php | ||
|
|
||
| namespace Tests\Resources; | ||
|
|
||
| use App\Http\Resources\PolicyResource; | ||
| use App\Policy; | ||
| use Illuminate\Foundation\Testing\RefreshDatabase; | ||
| use Tests\TestCase; | ||
|
|
||
| class PolicyResourceTest extends TestCase { | ||
| use RefreshDatabase; | ||
|
|
||
| public function testActiveFrom(): void { | ||
| $policy = Policy::create([ | ||
| 'policy_type' => 'terms-of-use', | ||
| 'content_vue_file' => 'terms-of-use/example.vue', | ||
| 'active_from' => '2022-02-02', | ||
| ]); | ||
|
|
||
| $resource = new PolicyResource($policy); | ||
| $data = $resource->resolve(); | ||
|
|
||
| $this->assertSame( | ||
| '2022-02-02', | ||
| data_get($data, 'metadata.active_from'), | ||
| ); | ||
| } | ||
|
|
||
| public function testActiveFromNull(): void { | ||
| $policy = Policy::create([ | ||
| 'policy_type' => 'terms-of-use', | ||
| 'content_vue_file' => 'terms-of-use/example.vue', | ||
| ]); | ||
|
|
||
| $resource = new PolicyResource($policy); | ||
| $data = $resource->resolve(); | ||
|
|
||
| $this->assertSame( | ||
| null, | ||
| data_get($data, 'metadata.active_from'), | ||
| ); | ||
| } | ||
|
|
||
| public function testActiveFromNullExplicit(): void { | ||
| $policy = Policy::create([ | ||
| 'policy_type' => 'terms-of-use', | ||
| 'content_vue_file' => 'terms-of-use/example.vue', | ||
| 'active_from' => null, | ||
| ]); | ||
|
|
||
| $resource = new PolicyResource($policy); | ||
| $data = $resource->resolve(); | ||
|
|
||
| $this->assertSame( | ||
| null, | ||
| data_get($data, 'metadata.active_from'), | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| <?php | ||
|
|
||
| namespace Http\Controllers; | ||
| namespace Tests\Routes; | ||
|
|
||
| use App\Policy; | ||
| use Carbon\CarbonImmutable; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.