endpoints for upcoming, current and all policies of a type#1214
Merged
Conversation
a small cleanup for consistency `Routes` seems to be favored #1207 (review)
deer-wmde
marked this pull request as ready for review
July 24, 2026 10:11
dati18
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds routes
Two observations:
1. api route order matters
this one works:
this one doesnt:
v1/policies/{policy_type}swallows the later ones:2. Explicit nulling of
active_fromDue to our PolicyFactory implementation we need to set
active_fromtonullif we want it to be not filled.this works:
this fills with
'active_from' => now()https://phabricator.wikimedia.org/T432714