Create endpoint to get specific policy by type and active_from date#1210
Merged
Conversation
tarrow
approved these changes
Jul 20, 2026
tarrow
left a comment
tarrow
left a comment
Contributor
There was a problem hiding this comment.
looks fine to me; paired with @rosalieper on this; took a short look away and then back again.
I was happy that we reused the Resource; this feels like exactly what we intended to be possible to do.
I was also happy with our decisions to use the Validator and its safe() function.
I'm slightly less happy with the global abort(). I feel like it would have been nicer to call this on an injected Request but this does follow the very terse advice on Error Handling.
We also read about Resource Controllers and wondered if this is a pattern we ought to adopt in the future. For now we decided not to look at this further and inject another interesting but inconsistent pattern.
dati18
pushed a commit
that referenced
this pull request
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: T432339