Skip to content

Fix CUTLASS local work driver setup#212

Merged
awvwgk merged 1 commit into
wavefunction91:skalafrom
DCM-Uni-Paderborn:gauxc-cutlass-build-fixes
Jun 8, 2026
Merged

Fix CUTLASS local work driver setup#212
awvwgk merged 1 commit into
wavefunction91:skalafrom
DCM-Uni-Paderborn:gauxc-cutlass-build-fixes

Conversation

@DCM-Uni-Paderborn

@DCM-Uni-Paderborn DCM-Uni-Paderborn commented Jun 6, 2026

Copy link
Copy Markdown

This PR fixes two small setup issues encountered when building and selecting the CUTLASS local work driver from downstream projects such as CP2K.

Changes

  • Use direct CMake boolean checks for fetched ExchCXX and IntegratorXX package discovery.
  • Propagate CMAKE_POSITION_INDEPENDENT_CODE to fetched ExchCXX and IntegratorXX targets when they are built as GauXC subprojects.
  • Normalize local work driver names by trimming whitespace and uppercasing via unsigned-character-safe std::toupper handling.

Motivation

The PIC propagation avoids relocation/link issues when GauXC is built as part of a shared downstream library with fetched static dependencies. The local work driver normalization makes inputs such as Scheme1-CUTLASS robust against surrounding whitespace and avoids undefined behavior from passing signed chars directly to std::toupper.

Validation

  • git diff --check: OK
  • Line-length check on touched files: OK
  • cmake -S . -B /tmp/gauxc-cutlass-build-fixes-configure -DGAUXC_ENABLE_MPI=OFF -DGAUXC_ENABLE_OPENMP=OFF -DGAUXC_ENABLE_TESTS=OFF -DGAUXC_ENABLE_HDF5=OFF -DGAUXC_ENABLE_ONEDFT=OFF -DCMAKE_POSITION_INDEPENDENT_CODE=ON: OK
  • cmake --build /tmp/gauxc-cutlass-build-fixes-configure -j 4: OK

@awvwgk awvwgk changed the base branch from skala to master June 8, 2026 11:53
@awvwgk awvwgk changed the base branch from master to skala June 8, 2026 11:54
@awvwgk awvwgk merged commit 36aeab8 into wavefunction91:skala Jun 8, 2026
2 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants