docs: filter pushdown is connected, not future work - #9637
Open
jackylee-ch wants to merge 1 commit into
Open
Conversation
VortexScanBuilder has implemented SupportsPushDownV2Filters since vortex-data#7785, and the converted predicate reaches native code as the ScanOptions filter. The guide still described it as infrastructure that exists but is not wired up, so a developer reading it plans around a limitation that is gone. The Future Work section keeps the Scan API Source trait migration, which is still outstanding. Signed-off-by: jackylee <qcsd2011@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guide called filter pushdown unconnected and "planned future work". It was connected in #7785:
VortexScanBuilderimplementsSupportsPushDownV2Filtersand the converted expression reachesnative code as the
ScanOptionsfilter, so a developer reading this plans around a limitation thatno longer exists.
The Future Work section keeps the
Sourcetrait migration, which is still outstanding.Tests
make -C docs htmlsucceeds under the repo's--fail-on-warning, same warning count as develop.AI assistance
Written with agentic AI assistance; I traced the pushdown path end to end before editing.