Skip to content

refactor(dict): clarify compute invariants - #9632

Open
connortsui20 wants to merge 1 commit into
developfrom
ct/dict-compute-cleanup
Open

refactor(dict): clarify compute invariants#9632
connortsui20 wants to merge 1 commit into
developfrom
ct/dict-compute-cleanup

Conversation

@connortsui20

Copy link
Copy Markdown
Member

Summary

Cleans up dictionary scalar-function pushdown and code selection without changing behavior.

Changes

Clarifies the pushdown guards and unsafe invariants, and documents why take and filter reset all_values_referenced.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 added the changelog/chore A trivial change label Aug 25, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 25, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 23.86%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
✅ 2108 untouched benchmarks
⏩ 106 skipped benchmarks1
🗄️ 4 archived benchmarks run2

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime arrow_checked_add_u32_neon[16384] 20.4 µs 12.4 µs +65.06%
WallTime words_gather_scalar_avx2[65536] 9.5 µs 8.3 µs +14.6%
Simulation compact[(2048, 90)] 1.5 µs 1.4 µs +11.89%
Simulation compress_fsst[(500, 64, 4)] 488.1 µs 439 µs +11.19%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/dict-compute-cleanup (0bd99e6) with develop (ee1ac25)

Open in CodSpeed

Footnotes

  1. 106 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant