Skip to content

fix(bench): include file open in random-access reopen timings - #9631

Draft
lwwmanning wants to merge 1 commit into
developfrom
wm/random-access-reopen-timing
Draft

fix(bench): include file open in random-access reopen timings#9631
lwwmanning wants to merge 1 commit into
developfrom
wm/random-access-reopen-timing

Conversation

@lwwmanning

Copy link
Copy Markdown
Contributor

Summary

--open-mode reopen creates each accessor outside the recorded timing interval. Its -footer measurements therefore exclude file-open and metadata parsing costs.

Changes

Create the accessor inside each timed reopen iteration. Cached mode still opens once and reuses its accessor.

🤖 Generated with Claude Code

Signed-off-by: Will Manning <will@willmanning.io>
@codspeed-hq

codspeed-hq Bot commented Aug 25, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 21.99%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
✅ 2108 untouched benchmarks
⏩ 106 skipped benchmarks1
🗄️ 4 archived benchmarks run2

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime arrow_checked_add_u32_neon[16384] 20.4 µs 12.6 µs +62.12%
Simulation compact[(2048, 90)] 1.5 µs 1.4 µs +11.89%
Simulation compress_fsst[(500, 64, 4)] 488.1 µs 441.6 µs +10.52%
Simulation compress_fsst[(500, 64, 8)] 524.9 µs 475.1 µs +10.48%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing wm/random-access-reopen-timing (e003545) with develop (ee1ac25)

Open in CodSpeed

Footnotes

  1. 106 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant