fix(bench): include file open in random-access reopen timings - #9631
fix(bench): include file open in random-access reopen timings#9631lwwmanning wants to merge 1 commit into
Conversation
Signed-off-by: Will Manning <will@willmanning.io>
Merging this PR will improve performance by 21.99%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | arrow_checked_add_u32_neon[16384] |
20.4 µs | 12.6 µs | +62.12% |
| ⚡ | Simulation | compact[(2048, 90)] |
1.5 µs | 1.4 µs | +11.89% |
| ⚡ | Simulation | compress_fsst[(500, 64, 4)] |
488.1 µs | 441.6 µs | +10.52% |
| ⚡ | Simulation | compress_fsst[(500, 64, 8)] |
524.9 µs | 475.1 µs | +10.48% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing wm/random-access-reopen-timing (e003545) with develop (ee1ac25)
Footnotes
-
106 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩
Summary
--open-mode reopencreates each accessor outside the recorded timing interval. Its-footermeasurements therefore exclude file-open and metadata parsing costs.Changes
Create the accessor inside each timed reopen iteration. Cached mode still opens once and reuses its accessor.
🤖 Generated with Claude Code