CI: don't pin NIC IRQs to housekeeping CPUs - #9568
Conversation
4d90a57 to
5efc83f
Compare
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
5efc83f to
985d357
Compare
Polar Signals Profiling ResultsLatest Run
Previous Runs (3)
Powered by Polar Signals Cloud |
Benchmarks: PolarSignals Profiling 📖Commits: PR datafusion / vortex-file-compressed / ns (1.014x ➖, 1↑ 1↓)
No file size changes detected. |
Benchmarks: FineWeb NVMe 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.988x ➖, 0↑ 0↓)
datafusion / vortex-compact / ns (0.993x ➖, 0↑ 0↓)
datafusion / parquet / ns (1.001x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.993x ➖, 1↑ 0↓)
duckdb / vortex-compact / ns (1.007x ➖, 0↑ 1↓)
duckdb / parquet / ns (0.996x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: TPC-H SF=1 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.988x ➖, 0↑ 0↓)
datafusion / vortex-compact / ns (1.013x ➖, 0↑ 0↓)
datafusion / parquet / ns (1.012x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed / ns (1.013x ➖, 0↑ 1↓)
duckdb / vortex-compact / ns (1.010x ➖, 0↑ 2↓)
duckdb / parquet / ns (0.999x ➖, 0↑ 0↓)
No file size changes detected. |
Merging this PR will degrade performance by 11.5%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | cold_misaligned[(16, 64)] |
380.2 µs | 431.9 µs | -11.96% |
| ❌ | WallTime | words_gather_scalar_avx2[65536] |
8.3 µs | 9.3 µs | -11.7% |
| ❌ | Simulation | compress_fsst[(500, 64, 8)] |
530.5 µs | 595 µs | -10.85% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing myrrc/no-net-irq-pin-in-ci (985d357) with develop (ef43456)
Footnotes
-
54 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Benchmarks: Clickbench Sorted on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.006x ➖, 0↑ 1↓)
datafusion / vortex-compact / ns (1.006x ➖, 0↑ 1↓)
datafusion / parquet / ns (1.010x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.006x ➖, 0↑ 1↓)
duckdb / vortex-compact / ns (1.027x ➖, 0↑ 0↓)
duckdb / parquet / ns (0.989x ➖, 0↑ 0↓)
File Size Changes (200 files changed, +0.1% overall, 104↑ 96↓)
Totals:
|
Benchmarks: String Encoding 📖Commits: PR vortex / vortex-file-compressed / ms (1.005x ➖, 0↑ 0↓)
vortex / vortex-file-compressed / % (1.000x ➖, 0↑ 0↓)
|
Benchmarks: FineWeb S3 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.042x ➖, 0↑ 1↓)
datafusion / vortex-compact / ns (0.977x ➖, 2↑ 1↓)
datafusion / parquet / ns (1.011x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.931x ➖, 0↑ 0↓)
duckdb / vortex-compact / ns (0.886x ➖, 1↑ 0↓)
duckdb / parquet / ns (0.638x ✅, 3↑ 1↓)
|
Benchmarks: Compression 📖Commits: PR vortex / vortex-file-compressed / ns (0.966x ➖, 1↑ 0↓)
vortex / vortex-file-compressed / bytes (1.000x ➖, 0↑ 0↓)
vortex / vortex-file-compressed / ratio (0.980x ➖, 1↑ 0↓)
vortex / parquet / ns (0.995x ➖, 0↑ 0↓)
vortex / parquet / bytes (1.000x ➖, 0↑ 0↓)
|
Benchmarks: Appian on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-compact / ns (0.997x ➖, 0↑ 0↓)
datafusion / parquet / ns (1.001x ➖, 0↑ 0↓)
duckdb / vortex-compact / ns (0.990x ➖, 0↑ 0↓)
duckdb / parquet / ns (0.999x ➖, 0↑ 0↓)
File Size Changes (10 files changed, -63.8% overall, 0↑ 10↓)
Totals:
|
Benchmarks: Statistical and Population Genetics 📖Commits: PR How to read Verdict and Engines
duckdb / vortex-file-compressed / ns (0.965x ➖, 2↑ 1↓)
duckdb / vortex-compact / ns (0.964x ➖, 2↑ 1↓)
duckdb / parquet / ns (0.994x ➖, 0↑ 0↓)
No file size changes detected. |
Benchmarks: TPC-DS SF=1 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.996x ➖, 1↑ 0↓)
datafusion / vortex-compact / ns (0.993x ➖, 1↑ 1↓)
datafusion / parquet / ns (0.995x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.996x ➖, 4↑ 5↓)
duckdb / vortex-compact / ns (0.994x ➖, 1↑ 1↓)
duckdb / parquet / ns (1.002x ➖, 1↑ 6↓)
No file size changes detected. |
Benchmarks: TPC-H SF=10 on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (1.003x ➖, 0↑ 0↓)
datafusion / vortex-compact / ns (1.005x ➖, 0↑ 0↓)
datafusion / parquet / ns (1.001x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.999x ➖, 0↑ 0↓)
duckdb / vortex-compact / ns (1.009x ➖, 0↑ 0↓)
duckdb / parquet / ns (0.996x ➖, 1↑ 0↓)
No file size changes detected. |
Benchmarks: Clickbench on NVME 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.998x ➖, 0↑ 0↓)
datafusion / vortex-compact / ns (0.999x ➖, 0↑ 0↓)
datafusion / parquet / ns (1.001x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (0.995x ➖, 2↑ 2↓)
duckdb / vortex-compact / ns (1.012x ➖, 0↑ 2↓)
duckdb / parquet / ns (1.013x ➖, 1↑ 2↓)
No file size changes detected. |
Benchmarks: TPC-H SF=1 on S3 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-file-compressed / ns (0.977x ➖, 1↑ 1↓)
datafusion / vortex-compact / ns (1.119x ➖, 0↑ 2↓)
datafusion / parquet / ns (1.000x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed / ns (1.077x ➖, 0↑ 2↓)
duckdb / vortex-compact / ns (0.992x ➖, 0↑ 1↓)
duckdb / parquet / ns (0.996x ➖, 0↑ 0↓)
|
Benchmarks: TPC-H SF=10 on S3 📖Commits: PR How to read Verdict and Engines
datafusion / vortex-compact / ns (1.068x ➖, 0↑ 3↓)
datafusion / parquet / ns (1.012x ➖, 1↑ 2↓)
duckdb / vortex-compact / ns (1.004x ➖, 1↑ 0↓)
duckdb / parquet / ns (1.001x ➖, 0↑ 0↓)
|
Benchmarks: Random Access 📖Commits: PR How to read Verdict and Engines
random-access / vortex-file-compressed / ns (1.079x ➖, 0↑ 1↓)
random-access / parquet / ns (0.996x ➖, 0↑ 0↓)
random-access / lance / ns (0.785x ✅, 1↑ 0↓)
|
#6901 introduced pinning all IRQs to two housekeeping CPUs.
This is an issue for S3 tests like fineweb-s3 where network is the
bottleneck.
Don't pin NIC IRQs to housekeeping CPUs so all cores can process them.