fix(rsc): generate sourcemaps for code transforms #1294
Open
Kinfe123 wants to merge 2 commits into
Open
Conversation
Kinfe123
marked this pull request as ready for review
July 17, 2026 23:37
Kinfe123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1122.
Three
@vitejs/plugin-rschooks changed generated code without returning sourcemaps:rsc:vite-client-raw-importrsc:virtual:vite-rsc/assets-manifestrsc:inject-async-local-storageThis updates those edits to use
MagicStringand return boundary-level maps, allowing Rolldown to compose correct final sourcemaps instead of reportingSOURCEMAP_BROKEN.A focused E2E test builds an isolated starter fixture with
--sourcemapand verifies the build succeeds without incorrect-sourcemap warnings.Validation
pnpm -C packages/plugin-rsc buildpnpm -C packages/plugin-rsc tscpnpm -C packages/plugin-rsc test --runpnpm -C packages/plugin-rsc test-e2e sourcemappnpm -C packages/plugin-rsc test-e2e starterpnpm -C packages/plugin-rsc/examples/starter build --sourcemappnpm exec oxfmt --check packages/plugin-rsc/src/plugin.ts packages/plugin-rsc/e2e/sourcemap.test.ts