fix(delivery): 255-safe provenance descriptions + loud upload port (#131 findings) - #132
Merged
Merged
Conversation
…riptions + loud upload port Run-0's historical upload stranded an orphan: the file uploaded but Appwrite rejected its metadata document (description attribute caps at 255 chars; the prose-prefixed C-15 provenance exceeded it), and the store module's graceful degradation only logged the error — the port's ledger then falsely claimed success. Two fixes: provenance.compact_description (delivery/, pipeline-core- free) emits compact JSON provenance guaranteed <=255 with fail-loud refusal to truncate, used by both historical description paths; _ContractStorePort.upload now inspects the OperationResult and RAISES on success=False — upstream graceful degradation must never silently strand our artifacts. Refs #131 (run-0 delivery verification). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run-0 verification (#131) found the historical upload stranded as an orphan file: bytes in the bucket, metadata document rejected (
description> 255 chars — the C-15 prose prefix), error only logged by the store's graceful degradation, port ledger falsely green.delivery/provenance.compact_description: compact JSON provenance guaranteed ≤255, fail-loud (never truncate silently); both description paths use it; pipeline-core-free and unit-tested._ContractStorePort.uploadnow raises onsuccess=False— upstream graceful degradation can't silently strand our artifacts again.A rerun after this merge heals the gap: dedup is document-keyed, so the orphan (no document) won't block a fresh historical upload. 🤖 Generated with Claude Code