Release v1.10.1 — arrow.load wire-contract ordering validation - #207
Merged
Conversation
…aping (#199 item 1, C-72) → v1.10.1 (#206) load reconstructed frames positionally but never checked the 'sample' column save wrote as the order contract — a reordered, truncated, or foreign-rewritten parquet reshaped plausible floats into the wrong sample slots silently. Now fails loud (ValueError) on: row count not a positive multiple of n_samples; sample column deviating from tile(arange(S), N); time/unit not constant within a sample block (cross-cell swaps the tile check alone cannot see). Whole-cell block reorders remain loadable (consistent tables). Implements the check views-postprocessing ADR-013 §4.5(b) made every consumer run themselves. Register C-72; #199 item 2 (mmap/partitioned) stays open. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes development → main for v1.10.1 (fail-loud PATCH;
CONFORMANCE_FLOORstays1.0.0).Ships
io.arrow.loadnow validates the wire-contract row order before its positional reshape (#199 item 1, register C-72): raisesValueErroron truncated/filtered tables, row-level reorders breaking the writtentile(arange(S), N)sample order, and cross-cell row swaps (time/unitnot constant within a sample block). Previously these reshaped plausible floats into the wrong sample slots silently; consumers had to run the check themselves per views-postprocessing ADR-013 §4.5(b) — the leaf now hardens all of them at once. Whole-cell block reorders remain loadable (consistent tables). #199 item 2 (mmap/partitioned reading) stays open.Merge with a MERGE COMMIT (never squash) — main carries squash release commits development lacks.
Gate: ruff · mypy strict (3.10+3.11) · pytest 100% line+branch · validate_docs (
v1.10 ~ 1.10.1 OK) — all green; PR #206 CI green. Trial merge: zero conflicts.🤖 Generated with Claude Code