mdns: apply network-probing fix from mdns_listen to mdns_serve - #63
Draft
Blaxar wants to merge 1 commit into
Draft
mdns: apply network-probing fix from mdns_listen to mdns_serve#63Blaxar wants to merge 1 commit into
Blaxar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long story short:
allocawas invoked in the main (not returning) loop ofmdns_serve, so as long as we don't get out of said loop: nothing gets unwinned (stack memory by default, heap memory if built if-fsplit-stack, at least withgccon Linux-based systems) and memory is slowly munched away over the lifetime of whatever program relies on this.As the commit message already hints: there was a similar fix applied to
mdns_listenwhich just consists in havingallocabeing called into its own function (which will be unwinned for sure), but this was still missing formdns_serve: #15