Fix the jump state bug#138
Merged
Merged
Conversation
… jumps after you released the second jump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the current version if you keep holding the first jump, and then press the second jump, and then release the second jump, the physics inspector would still think you're holding 2 jumps after you released the second jump.
I believe the issue is this method:
ConsistencyTrackerMod/PhysicsLog/PhysicsLogger.cs
Lines 709 to 720 in 719ce60
This is my understanding of the issue: I kept holding the first jump, so
Input.Jump.Checkwas always true -> I pressed the second jump, soPhysicsLogHoldingSecondJumpwas set to true -> I released the second jump while keeping holding the first jump, butPhysicsLogHoldingSecondJumpwas still true.This pull request makes it check how many jump keys are held manually, instead of using
Input.Jump.CheckandInput.Jump.Pressed. From what I've tested, it works pretty fine and fixes the issue.