RSDK-140006 add color control to details#760
Open
Devin T. Currie (DTCurrie) wants to merge 2 commits into
Open
RSDK-140006 add color control to details#760Devin T. Currie (DTCurrie) wants to merge 2 commits into
Devin T. Currie (DTCurrie) wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: aa1ef4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick add to resolve a request. We had the tools for it, so it was easy to add. One thing, I had to move away from
colorUtilonMesh.svelteto return a new color to make sure changes are actually caught and rendered.$derivedre-publishes only when its value changes by strict===equality checks. Since the reference never changed, Svelte considered the derived unchanged, and Threlte never re-applied it to<T.MeshToonMaterial {color}>.