Skip to content

change confusing connection dialog names#752

Open
Grant Mulitz (gmulz) wants to merge 1 commit into
mainfrom
gmulitz-better-connect-names
Open

change confusing connection dialog names#752
Grant Mulitz (gmulz) wants to merge 1 commit into
mainfrom
gmulitz-better-connect-names

Conversation

@gmulz

@gmulz Grant Mulitz (gmulz) commented Jun 6, 2026

Copy link
Copy Markdown
Member

i always get confused what "host" mean and what "signaling address" means. there's already a "host" name on the app that means the literal name of the computer, but here "host" means "remote address", and "signaling address" sounds like it should mean the DNS address but it actually means the address of the signaling server

made copy changes to make this clearer

image

(what host means in regular app:)

image

@changeset-bot

changeset-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8eff801

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://viamrobotics.github.io/visualization/pr-preview/pr-752/

Built to branch gh-pages at 2026-06-06 02:14 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@DTCurrie

Devin T. Currie (DTCurrie) commented Jun 9, 2026

Copy link
Copy Markdown
Member

I am not opposed to this, but "host" and "signalingAddress" are both taken straight from the TypeScript SDK, so there may be a broader conversation around naming for these fields for now.

Either way, we are pulling the connection out to a plugin, and so it would make more sense to address this there.

Also may be worth noting the app is actually wrong here. What it is calling host in the status dropdown is actually the hostname field.

And what we need to pass to the host field in the dial config comes from the robot's remoteAddress field. so the app and the SDK don't agree on that field name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants