You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i always get confused what "host" mean and what "signaling address" means. there's already a "host" name on the app that means the literal name of the computer, but here "host" means "remote address", and "signaling address" sounds like it should mean the DNS address but it actually means the address of the signaling server
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I am not opposed to this, but "host" and "signalingAddress" are both taken straight from the TypeScript SDK, so there may be a broader conversation around naming for these fields for now.
Either way, we are pulling the connection out to a plugin, and so it would make more sense to address this there.
Also may be worth noting the app is actually wrong here. What it is calling host in the status dropdown is actually the hostname field.
And what we need to pass to the host field in the dial config comes from the robot's remoteAddress field. so the app and the SDK don't agree on that field name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i always get confused what "host" mean and what "signaling address" means. there's already a "host" name on the app that means the literal name of the computer, but here "host" means "remote address", and "signaling address" sounds like it should mean the DNS address but it actually means the address of the signaling server
made copy changes to make this clearer
(what host means in regular app:)