RSDK-11728 — Remove get_image, render_frame, and format#1056
Merged
Conversation
sean yu (hexbabe)
requested review from
Allison Chiang (allisonschiang) and
lia (lia-viam)
Contributor
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
sean yu (hexbabe)
force-pushed
the
RSDK-11728
branch
from
50afeab to
17eba43
Compare
sean yu (hexbabe)
force-pushed
the
RSDK-11728
branch
from
17eba43 to
5ff4f8a
Compare
| assert is_monitored is True | ||
|
|
||
| is_monitored = client._is_safety_heartbeat_monitored("/viam.component.camera.v1.CameraService/GetImage") | ||
| is_monitored = client._is_safety_heartbeat_monitored("/viam.component.camera.v1.CameraService/GetImages") |
Contributor
Author
There was a problem hiding this comment.
not sure what this is and not sure if we can directly substitute GetImages here
…at enum field completely removed
sean yu (hexbabe)
changed the title
sean yu (hexbabe)
changed the title
sean yu (hexbabe)
changed the title
Naveed Jooma (njooma)
requested changes
Dec 30, 2025
Comment on lines
-25
to
-28
| "camera": { | ||
| "func": "get_image", | ||
| "packagePath": "viam.components" | ||
| }, |
There was a problem hiding this comment.
do not remove this, but replace with get_images
Contributor
Author
There was a problem hiding this comment.
got it. Addressed
| camera = self.get_resource(name) | ||
| async def GetImage(self, stream: Stream) -> None: | ||
| """Deprecated: Use GetImages instead.""" | ||
| raise NotImplementedError("GetImage is deprecated. Use GetImages instead.") |
There was a problem hiding this comment.
raise NotSupportedError instead:
from viam.errors import NotSupportedError
...
raise NotSupportedError("GetImage is deprecated. Use GetImages instead.")There was a problem hiding this comment.
NotSupportedError will bubble up the gRPC stack appropriately
Contributor
Author
There was a problem hiding this comment.
got it. Addressed
| await stream.send_message(response) | ||
| async def RenderFrame(self, stream: Stream) -> None: | ||
| """Deprecated: Use GetImages instead.""" | ||
| raise NotImplementedError("RenderFrame is deprecated. Use GetImages instead.") |
There was a problem hiding this comment.
Same here re: NotSupportedError
Contributor
Author
There was a problem hiding this comment.
got it. Addressed
Naveed Jooma (njooma)
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://viam.atlassian.net/browse/RSDK-11728
Not for merging immediately; getting this ready for Jan 5th when all dependent code has been updated.