RSDK-8714: Input Controller wrappers#70
Conversation
Ethan (stuqdog)
left a comment
Ethan (stuqdog)
left a comment
There was a problem hiding this comment.
A couple minor things but generally looks good to me! I confess I don't have any experience with kotlin or java particularly however, so definitely might've missed something.
| plugins { | ||
| id "com.github.hierynomus.license-report" version "0.16.1" | ||
| id "org.jetbrains.kotlin.jvm" version "2.0.0" | ||
|
|
There was a problem hiding this comment.
(minor) probably should get rid of this newline?
| override fun getManager(): ResourceManager { | ||
| return this.manager | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
(minor) here and in subsequent files, we should add a newline character here for POSIX compliance.
|
Putting on ice for now -- need to take a look at removing the kotlin dependency |
|
Hey gloriacai01 — this PR has been approved and CI has been green for 421+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey gloriacai01 — this PR has been approved and CI has been green for 428+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey gloriacai01 — this PR has been approved and CI has been green for 433+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey gloriacai01 — this PR has been approved and CI has been green for 438+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey gloriacai01 — this PR has been approved and CI has been green for 443+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey gloriacai01 — this PR has been approved and CI has been green for 449+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey gloriacai01 — this PR has been approved and CI has been green for 454+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
3 participants
-input controller wrapper + associated tests
-added kotlinx coroutines library as a requirement in gradle for channel use in
streamEvents