Make VALYU_API_KEY skill input optional#74
Merged
Conversation
required: true forced skill-aware installers and agent harnesses to demand an API key up front, before the user ever saw the device flow - directly contradicting the skill body, which tells agents to use `valyu login` (device flow) so nobody has to paste a secret. Key entry is now optional, for headless/CI environments only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
skills/valyu-cli/SKILL.mddeclaredVALYU_API_KEYas a required input. Skill-aware installers/agent harnesses treat required inputs as blocking prompts, so on a fresh machine the first thing a user saw was "enter your API key" - no browser, no device flow. This contradicts the skill's own agent protocol ("mints and stores a scopedval_key, so an agent never has to ask a human to paste a secret") and buries the intendedvalyu loginUX.Reported from a real fresh-machine install: user was prompted for an API key immediately, browser never opened.
Fix
required: falsewith a description that steers tovalyu login(device flow) and reserves the env var for headless/CI.Frontmatter-only change - no code or tests affected. GitHub-sourced skill installs pick this up immediately; npm-packaged copies get it with the next release.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.