Conversation
Owner
Author
|
Added todos as comments so it can be published without done done and it can be updated later on |
MsSlacker
added
the
mergeWhenPassing
MsSlacker
requested changes
Jan 20, 2020
Collaborator
|
It should be marked as wip since you didn't finish it yet |
Owner
Author
|
I wanted to still publish it with the ones I have. Do you feel it's better if I wait for the remaining 2? |
Collaborator
|
I wait until it's finished imo |
Owner
Author
|
ok =) |
Owner
Author
|
Added, but still not done |
Owner
Author
|
@MsSlacker review pls |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.