grep: expand bundled numeric context options - #76
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
lhecker
left a comment
There was a problem hiding this comment.
I'm not entirely sure if I agree with the way this PR is written. It removes the Vec collect() optimization (os_args() returns a Vec IntoIterator), adds full UTF8 validation (is that necessary?), and is overall a lot more verbose than the old code.
I haven't thought it through, and so I may be mistaken, but I intuitively feel like the issue should be moderately easy to solve within the old code's structure.
Summary
--arguments, and non-UTF-8 arguments unchangedThe implementation is based only on the behavior specified in issue #68 and the original uutils grep code. No GNU source code was consulted or used.
Verification
cargo clippy --all-targets --all-features -- -D warningscargo fmt --all -- --checkgit diff --checkCloses #68